The best carry-on is the one that fits the airlines you fly most. Check their published limits first; the common “22 × 14 × 9 inch” size does not fit every regional or low-cost carrier.
Hard shells protect contents and clean easily but do not squeeze into a tight bin. Soft shells forgive overpacking and usually have an outside pocket for the things you need in the queue. Neither is better; pick by how you pack.
Four spinner wheels are easier in airports, two larger wheels are better on pavement. Whatever you choose, the wheels and the telescoping handle are what fail first, so favour brands that sell those parts separately.
An empty bag that weighs 8 pounds costs you 8 pounds of clothes on airlines with a weight limit. Lighter is worth paying for if you fly those carriers.
A real repair warranty beats a “lifetime” one that excludes airline damage. Read the exclusions before the reviews.